Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

feat: automatically publish releases #407

Merged
merged 19 commits into from
Jun 21, 2024
Merged

feat: automatically publish releases #407

merged 19 commits into from
Jun 21, 2024

Conversation

rdmitr
Copy link
Collaborator

@rdmitr rdmitr commented Jun 8, 2024

@rolznz
Copy link
Collaborator

rolznz commented Jun 10, 2024

oh wow, nice!

  • I don't think it should be linked to the wails workflow, can it be a separate workflow? and we can then run it on a specific branch I guess (EDIT: or did you plan to do it by tag)? otherwise we will get a huge number of drafts
  • Can you also upload the assets for the other distributions (RPI etc?)
  • What would also be a good way to link to the docker build (how would users easily run this exact version using docker)?

@rdmitr
Copy link
Collaborator Author

rdmitr commented Jun 10, 2024

@rolznz

Agreed! In fact, I feel it's about time to refactor the GH actions, sort of like Breez does it. We need clearly separated actions for building all the stuff, and a separate release action to run the builds, collect the artifacts, and publish the releases. I will look into it

@rdmitr
Copy link
Collaborator Author

rdmitr commented Jun 10, 2024

EDIT: or did you plan to do it by tag

Yeah, exactly. Pushing a new tag would trigger a release

@rolznz
Copy link
Collaborator

rolznz commented Jun 11, 2024

@rdmitr in the future it would be nice to also look if we create a draft release (and create a tag at that point) and then the automation runs at that point

# Conflicts:
#	.github/workflows/wails2.yaml
@rdmitr
Copy link
Collaborator Author

rdmitr commented Jun 17, 2024

@rolznz I have updated the PR to address the comments :)

I don't think it should be linked to the wails workflow, can it be a separate workflow? and we can then run it on a specific branch I guess

The workflow is now split into actions: first the top-level release.yaml action is triggered (by push for now, but that's for convenience when testing only), then it invokes the Raspberry Pi and Wails actions, followed by the publish-release.yaml action.

What would also be a good way to link to the docker build (how would users easily run this exact version using docker)?

Not sure how to deal with the Docker build, though. Guess we should create Docker images on release, and the users will simply pull the latest image?

Can you also upload the assets for the other distributions (RPI etc?)

Raspberry Pi archive added. However, I have noticed that the Raspberry Pi action publishes a raw zip file. This is problematic, since the executable bit is not preserved (but I see that the update.sh script fixes that). I have added a job step to also produce a .tar.bz2 archive, which is then published in the release. We need to update the update.sh script to fetch the .tar.bz2 archive; then, we will remove the old plain zip artifact from the action.

@rolznz
Copy link
Collaborator

rolznz commented Jun 18, 2024

@reneaaron does that sound ok to you RE: the change to the update.sh script?

@reneaaron
Copy link

I just found it weird to have a zip that contains a another archive, that's why I initially added the executable flags in the update script. No strong opinions here, I guess both is equally fine.

@rdmitr
Copy link
Collaborator Author

rdmitr commented Jun 19, 2024

@reneaaron agreed, but raw artifacts are not supposed to be used by the end users, I guess. When we publish a proper Github release, that outer ZIP archive goes away :)

@rolznz rolznz changed the title feat: automatically publish releases for Wails apps feat: automatically publish releases Jun 20, 2024
@rolznz rolznz merged commit 8682396 into master Jun 21, 2024
6 checks passed
@rolznz rolznz deleted the release-wails branch June 21, 2024 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create releases for NWC-next
3 participants